Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: suppress react-intl warnings #164

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Oct 19, 2023

This PR supresses the warnings from react-intl about pre-compiling the messages. See also formatjs/formatjs#3506

image

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Oct 19, 2023
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://formatjs.io/docs/guides/advanced-usage/#pre-compiling-messages

Maybe we can execute this at build time here and bundle the AST with the library?

@jonas-jonas
Copy link
Member Author

I tried, but that assumes that we extracted the message, and that format is different from ours. I couldn't get the CLI to compile our messages. If you know how, feel free. But we should get rid of this message.

@jonas-jonas jonas-jonas merged commit 36e85dd into main Oct 24, 2023
12 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixPrecompileWarning branch October 24, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants