Remove padding from HMAC generation to avoid confusion in URLs

ory · Jan 9, 2023 · e60949d · e60949d
1 parent 9279963
commit e60949d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/token/hmac/hmacsha.go b/token/hmac/hmacsha.go
@@ -186,7 +186,7 @@ func (c *HMACStrategy) GenerateHMACForString(ctx context.Context, text string) (
 	bytes := []byte(text)
 	hashBytes := c.generateHMAC(ctx, bytes, &signingKey)
 
-	b64 := base64.URLEncoding.EncodeToString(hashBytes)
+	b64 := base64.RawURLEncoding.EncodeToString(hashBytes)
 	return b64, nil
 }
 

diff --git a/token/hmac/hmacsha_test.go b/token/hmac/hmacsha_test.go
@@ -144,19 +144,19 @@ func TestGenerateFromString(t *testing.T) {
 	}{
 		{
 			text: "",
-			hash: "-n7EqD-bXkY3yYMH-ctEAGV8XLkU7Y6Bo6pbyT1agGA=",
+			hash: "-n7EqD-bXkY3yYMH-ctEAGV8XLkU7Y6Bo6pbyT1agGA",
 		},
 		{
 			text: " ",
-			hash: "zXJvonHTNSOOGj_QKl4RpIX_zXgD2YfXUfwuDKaTTIg=",
+			hash: "zXJvonHTNSOOGj_QKl4RpIX_zXgD2YfXUfwuDKaTTIg",
 		},
 		{
 			text: "Test",
-			hash: "TMeEaHS-cDC2nijiesCNtsOyBqHHtzWqAcWvceQT50g=",
+			hash: "TMeEaHS-cDC2nijiesCNtsOyBqHHtzWqAcWvceQT50g",
 		},
 		{
 			text: "AnotherTest1234",
-			hash: "zHYDOZGjzhVjx5r8RlBhpnJemX5JxEEBUjVT01n3IFM=",
+			hash: "zHYDOZGjzhVjx5r8RlBhpnJemX5JxEEBUjVT01n3IFM",
 		},
 	} {
 		hash, _ := cg.GenerateHMACForString(context.Background(), c.text)