Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Copy all values when sanitizing #455

Merged
merged 1 commit into from
Aug 7, 2020
Merged

refactor: Copy all values when sanitizing #455

merged 1 commit into from
Aug 7, 2020

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Aug 5, 2020

Minor improvement when looking at the code. Get returns just the first value.

A redo of #454.

@mitar mitar mentioned this pull request Aug 5, 2020
Closed
@mitar
Copy link
Contributor Author

mitar commented Aug 5, 2020

Are you by chance following your fosite fork on CircleCI? In those cases, builds do not work in the upstream which is why the CI does not trigger. It would be great to have the CI results though to make sure that everything behaves correctly!

OK, this didn't help. Are you sure I should not following the fork? Have you enabled CI for forked projects, see: https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

mitar
mitar commented Aug 5, 2020
View reviewed changes
request_test.go
assert.Equal(t, "fasdf", a.GetRequestForm().Get("baz"))
assert.Equal(t, "fasdf", a.GetRequestForm().Get("foo"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reordered things a bit, to make more sense.

@mitar
Copy link
Contributor Author

mitar commented Aug 5, 2020

I added tests.

@aeneasr aeneasr merged commit c80d0d4 into ory:master Aug 7, 2020
@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2020

Awesome, thank you!

@mitar mitar deleted the patch-1 branch August 13, 2020 00:48
@mitar mitar mentioned this pull request Aug 21, 2020
Merged
5 tasks
@aeneasr
Copy link
Member

aeneasr commented Aug 21, 2020

Are you by chance following your fosite fork on CircleCI? In those cases, builds do not work in the upstream which is why the CI does not trigger. It would be great to have the CI results though to make sure that everything behaves correctly!

OK, this didn't help. Are you sure I should not following the fork? Have you enabled CI for forked projects, see: https://circleci.com/docs/2.0/oss/#build-pull-requests-from-forked-repositories

🤦

should work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitar @aeneasr