Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor token validation #63

Closed
aeneasr opened this issue Aug 3, 2016 · 0 comments
Closed

Refactor token validation #63

aeneasr opened this issue Aug 3, 2016 · 0 comments
Assignees
@aeneasr
Labels
breaking change Changes behavior in a breaking manner. feat New feature or request.
Milestone
0.2.0

Comments

@aeneasr
Copy link
Member

aeneasr commented Aug 3, 2016 •
edited
Loading

Token validation is conceptually broken at the moment. Instead, something similar to token introspection should be possible:

var TokenType int

const AccessToken tokenType = 1 // in handler / validation strategy

fosite.Introspect(token string) (fosite.Requester, error)
fosite.IntrospectStrict(token string, tt tokenType) (fosite.Requester, error)

Both iterate through all validators and return true if one of them validated successfully
@aeneasr aeneasr added feat New feature or request. docs labels Aug 3, 2016
@aeneasr aeneasr added this to the v1 milestone Aug 3, 2016
@aeneasr aeneasr self-assigned this Aug 3, 2016
@aeneasr aeneasr added the breaking change Changes behavior in a breaking manner. label Aug 3, 2016
@aeneasr aeneasr modified the milestones: 0.2.0, v1 Aug 3, 2016
aeneasr pushed a commit that referenced this issue Aug 6, 2016
handler: flatten packages closes #70
f41216c 
openid: don't autogrant openid scope - closes #68

all: clean up scopes / arguments - closes #66

all: composable factories - closes #64

all: refactor token validation - closes #63

all: remove mandatory scope - closes #62
@aeneasr aeneasr closed this as completed in a92c755 Aug 6, 2016
budougumi0617 added a commit to budougumi0617/fosite that referenced this issue May 10, 2019
@budougumi0617
all: composable factories, better token validation, better scope hand…
9c4e58e 
…ling and simplify structure

* readme: add gitter chat badge closes ory#67
* handler: flatten packages closes ory#70
* openid: don't autogrant openid scope - closes ory#68
* all: clean up scopes / arguments - closes ory#66
* all: composable factories - closes ory#64
* all: refactor token validation - closes ory#63
* all: remove mandatory scope - closes ory#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
breaking change Changes behavior in a breaking manner. feat New feature or request.
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@aeneasr