revoke_handler: respecting ErrInvalidRequest code #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DefinitelyNotAGoat
force-pushed
the
issue-379/respect_ErrInvalidRequest
branch
3 times, most recently
from
1252260 to
89c76f2
Compare
|
Thank you for fixing this! Could you add a test for this please? Also, please sign the CLA - thank you! :) |
|
For sure! Will do! |
|
Hi @aeneasr I am having difficulty accessing the CLA. It appears have trouble loading. I've gotten a couple 502's, but this is the latest error: |
DefinitelyNotAGoat
force-pushed
the
issue-379/respect_ErrInvalidRequest
branch
from
89c76f2 to
570214f
Compare
This commit modifies the case for ErrInvalidRequest in WriteRevocationResponse to respect the 400 error code and not fallthrough to ErrInvalidClient. Author: DefinitelyNotAGoat <baldrich@protonmail.com>
DefinitelyNotAGoat
force-pushed
the
issue-379/respect_ErrInvalidRequest
branch
from
570214f to
4d659cf
Compare
|
I tried again and was able to sign, also added the requested test cases. Thanks @aeneasr! |
|
Awesome - you rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#379
Proposed changes
This commit modifies the case for ErrInvalidRequest in
WriteRevocationResponse to respect the 400 error code
and not fallthrough to ErrInvalidClient.
Checklist