fix: [#754] Requester ID fix #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Nice! Maybe add a test so this never regresses? |
|
@aeneasr Modified one of the refresh token flow tests |
|
@vivshankar Care to refresh this PR with latest master? |
aeneasr
approved these changes
Feb 12, 2024
aeneasr
force-pushed
the
754-refresh-token-requester-ID-fix
branch
from
450cdbe
to
23b3ac5
Compare
james-d-elliott
pushed a commit
to james-d-elliott/fosite
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the problem is part of the #754 . This is not a breaking change.
Related Issue or Design Document
N/A
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments
This is a minor change that has no impact to existing flows. It merely serves to be consistent with the auth code flow implementation and caters for cases highlighted in the Github issue.