Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not store stacktrace in sentinel errors #823

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Sep 14, 2024

github.com/pkg/errors's New records a stack trace but for sentinel errors you do not want to record a stack trace of Go initialization. One should return errorsx.WithStack(ErrInvalidatedAuthorizeCode) to attach a stack trace with the error.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@mitar mitar requested a review from aeneasr as a code owner September 14, 2024 22:46
@aeneasr aeneasr merged commit 869a37c into ory:master Sep 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants