Implement RFC 8628 #826
Open
Implement RFC 8628 #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WriteAccessError is used to construct error responses as described in Section 5.2 of [RFC6749]. It is not limited to access token responses. Perhaps we should rename the function to Rfc6749TokenError.
feat: add the access token endpoint handling for device authorization flow
… auth/device code is expired
fix: add the OIDC handler for device flow
* fix: fix the refresh token issue * fix: fix the OIDC token missing issue
|
|
nsklikas
force-pushed
the
canonical-master
branch
from
7589ecc
to
73d570f
Compare
7 tasks
|
Looks like the conformity tests are failing because it tries to use this version of fosite on hydra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Design Document
Implements RFC 8628.
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments
This PR is based on the work done on #701, by @supercairos and @BuzzBumbleBee. That PR was based on an older version of fosite and was missing some features/tests.
Comments:
go.uber.org/mock/gomock(github.com/golang/mock/gomockis deprecated)AuthorizeExplicitGrantHandlerto generalize it to reduce code duplication