Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support all variations of responseTypes #104

Merged
merged 7 commits into from
Dec 8, 2021

Conversation

Demonsthere
Copy link
Collaborator

@Demonsthere Demonsthere commented Dec 3, 2021

Expand validation and add tests for the following variations of responseTypes:

  responseTypes:
    - id_token
    - code
    - token
    - code token
    - code id_token
    - id_token token
    - code id_token token

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@Demonsthere Demonsthere added bug Something is not working. tests Affects tests. labels Dec 3, 2021
@Demonsthere Demonsthere changed the title feat: support all variations of responsteTypes feat: support all variations of responseTypes Dec 3, 2021
@Demonsthere Demonsthere marked this pull request as ready for review December 3, 2021 13:37
@Demonsthere Demonsthere requested a review from piotrmsc as a code owner December 3, 2021 13:37
@Demonsthere Demonsthere requested a review from piotrmsc December 7, 2021 12:05
@piotrmsc piotrmsc merged commit a7a2caa into ory:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. tests Affects tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

response_type=id_token+token
2 participants