-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add redirect uris #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super solid, thanks @paulbdavis! Please consider some minor improvements, as listed below. Would you mind updating the CR syntax section in the ory/k8s repo?https://github.com/ory/k8s/blob/master/docs/helm/hydra-maester.md
Should the version of the API for the CRD be bumped? The issue is that if you are (like I am) running multiple versions of the maester in a k8s cluster in different namespaces (with multiple instances of hydra itself as well) you have to ensure they are all using the same version if the CRD changes. If the api version is bumped for the CRD, then multiple versions can co-exist (for testing, staggered upgrades, etc) |
I added a branch with this change that I can add to this PR here. |
@paulbdavis No, I don't think so. @piotrmsc how 'bout you? |
@jakkab IMO there's no need, helm upgrade should work as well as kubectl apply -f crd.yaml |
@paulbdavis if you need help with the CI, take a look at the configuration file here: ory/oathkeeper-maester@c1bcd3d. Instead of |
I've restarted the CI which failed with a network error I believe. |
Merged with #35 |
Adds redirect URIs to the CRD