Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for token_endpoint_auth_method #37

Merged
merged 1 commit into from
Nov 26, 2019
Merged

adding support for token_endpoint_auth_method #37

merged 1 commit into from
Nov 26, 2019

Conversation

amihalj
Copy link
Contributor

@amihalj amihalj commented Nov 25, 2019

in some cases default client_secret_basic auth method is not suitable.

Therefor it would be useful to expose token_endpoint_auth_method hydra API parameter to maester CRD

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aeneasr
aeneasr approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeneasr aeneasr requested a review from piotrmsc November 25, 2019 10:43
@aeneasr aeneasr merged commit cb8601c into ory:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amihalj @CLAassistant @aeneasr