feat: Sync mode - least work approach #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakkab
changed the title
kubadz
reviewed
Feb 7, 2020
|
LMK if good for 👀 |
kubadz
approved these changes
Feb 7, 2020
Demonsthere
approved these changes
Feb 11, 2020
|
@aeneasr Ready for your review. Please bear in mind it’s not a fully fledged sync mode, it just allows the controller to reconcile an existing CR that has not been modified, but for some reason the corresponding Oauth2 client is not present in Hydra. |
|
Looking good - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative approach to #4. Modify SyncPeriod to control intervals between forced reconciliations for each CR.