build: Update CRDs and k8s dependencies #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colunira
changed the title
|
Thank you! Could you look into the failing test cases please? :) |
|
Sure, I'm working on this in parallel with other tasks, so it may take a moment or two ;) |
|
@aeneasr PR is ready for review :) |
Demonsthere
reviewed
May 6, 2021
| @@ -36,7 +36,7 @@ const ( | |||
| // HydraAdmin defines the desired hydra admin instance to use for OAuth2Client | |||
| type HydraAdmin struct { | |||
| // +kubebuilder:validation:MaxLength=64 | |||
| // +kubebuilder:validation:Pattern=(^$|^https?://.*) | |||
| // +kubebuilder:validation:Pattern=`(^$|^https?://.*)` | |||
|
Please regenerate manifests and imho we can merge this, good job! :) |
|
looks like it wasn't regenerated yet? |
They are, during review we saw some changes, but traced them to a version mismatch of kubebuilder. The CRD in this PR is consistent with kubernetes 1.20. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRDs in version v1beta1 are deprecated. Update the version to v1 and bump k8s dependencies.