feat: allow injecting extra fosite strategies

ory · Oct 12, 2023 · 815e82e · 815e82e
1 parent a0c06ec
commit 815e82e
Show file tree

Hide file tree

Showing 5 changed files with 381 additions and 7 deletions.
diff --git a/driver/factory.go b/driver/factory.go
@@ -8,6 +8,7 @@ import (
 	"io/fs"
 
 	"github.com/ory/hydra/v2/driver/config"
+	"github.com/ory/hydra/v2/fositex"
 	"github.com/ory/x/configx"
 	"github.com/ory/x/logrusx"
 	"github.com/ory/x/otelx"
@@ -22,10 +23,11 @@ type (
 		opts     []configx.OptionModifier
 		config   *config.DefaultProvider
 		// The first default refers to determining the NID at startup; the second default referes to the fact that the Contextualizer may dynamically change the NID.
-		skipNetworkInit bool
-		tracerWrapper   TracerWrapper
-		extraMigrations []fs.FS
-		goMigrations    []popx.Migration
+		skipNetworkInit  bool
+		tracerWrapper    TracerWrapper
+		extraMigrations  []fs.FS
+		goMigrations     []popx.Migration
+		fositexFactories []fositex.Factory
 	}
 	OptionsModifier func(*options)
 
@@ -94,6 +96,12 @@ func WithGoMigrations(m ...popx.Migration) OptionsModifier {
 	}
 }
 
+func WithExtraFositeFactories(f ...fositex.Factory) OptionsModifier {
+	return func(o *options) {
+		o.fositexFactories = append(o.fositexFactories, f...)
+	}
+}
+
 func New(ctx context.Context, sl *servicelocatorx.Options, opts []OptionsModifier) (Registry, error) {
 	o := newOptions()
 	for _, f := range opts {
@@ -132,6 +140,8 @@ func New(ctx context.Context, sl *servicelocatorx.Options, opts []OptionsModifie
 		r.WithTracerWrapper(o.tracerWrapper)
 	}
 
+	r.WithExtraFositeFactories(o.fositexFactories)
+
 	if err = r.Init(ctx, o.skipNetworkInit, false, ctxter, o.extraMigrations, o.goMigrations); err != nil {
 		l.WithError(err).Error("Unable to initialize service registry.")
 		return nil, err

diff --git a/driver/registry.go b/driver/registry.go
@@ -10,6 +10,7 @@ import (
 
 	"go.opentelemetry.io/otel/trace"
 
+	"github.com/ory/hydra/v2/fositex"
 	"github.com/ory/hydra/v2/internal/kratos"
 	"github.com/ory/x/httprouterx"
 	"github.com/ory/x/popx"
@@ -59,6 +60,9 @@ type Registry interface {
 	x.HTTPClientProvider
 	GetJWKSFetcherStrategy() fosite.JWKSFetcherStrategy
 
+	WithExtraFositeFactories(f []fositex.Factory) Registry
+	ExtraFositeFactories() []fositex.Factory
+
 	contextx.Provider
 	config.Provider
 	persistence.Provider

diff --git a/driver/registry_base.go b/driver/registry_base.go
@@ -90,6 +90,7 @@ type RegistryBase struct {
 	fc              *fositex.Config
 	publicCORS      *cors.Cors
 	kratos          kratos.Client
+	fositeFactories []fositex.Factory
 }
 
 func (m *RegistryBase) GetJWKSFetcherStrategy() fosite.JWKSFetcherStrategy {
@@ -417,6 +418,16 @@ func (m *RegistryBase) OAuth2Config() *fositex.Config {
 	return m.fc
 }
 
+func (m *RegistryBase) ExtraFositeFactories() []fositex.Factory {
+	return m.fositeFactories
+}
+
+func (m *RegistryBase) WithExtraFositeFactories(f []fositex.Factory) Registry {
+	m.fositeFactories = f
+
+	return m.r
+}
+
 func (m *RegistryBase) OAuth2ProviderConfig() fosite.Configurator {
 	if m.oc != nil {
 		return m.oc

diff --git a/fositex/config.go b/fositex/config.go
@@ -29,9 +29,10 @@ type configDependencies interface {
 	x.HTTPClientProvider
 	GetJWKSFetcherStrategy() fosite.JWKSFetcherStrategy
 	ClientHasher() fosite.Hasher
+	ExtraFositeFactories() []Factory
 }
 
-type factory func(config fosite.Configurator, storage interface{}, strategy interface{}) interface{}
+type Factory func(config fosite.Configurator, storage interface{}, strategy interface{}) interface{}
 
 type Config struct {
 	deps configDependencies
@@ -45,7 +46,7 @@ type Config struct {
 }
 
 var defaultResponseModeHandler = fosite.NewDefaultResponseModeHandler()
-var defaultFactories = []factory{
+var defaultFactories = []Factory{
 	compose.OAuth2AuthorizeExplicitFactory,
 	compose.OAuth2AuthorizeImplicitFactory,
 	compose.OAuth2ClientCredentialsGrantFactory,
@@ -70,7 +71,8 @@ func NewConfig(deps configDependencies) *Config {
 }
 
 func (c *Config) LoadDefaultHandlers(strategy interface{}) {
-	for _, factory := range defaultFactories {
+	factories := append(defaultFactories, c.deps.ExtraFositeFactories()...)
+	for _, factory := range factories {
 		res := factory(c, c.deps.Persister(), strategy)
 		if ah, ok := res.(fosite.AuthorizeEndpointHandler); ok {
 			c.authorizeEndpointHandlers.Append(ah)