docs: add comments to explain why we use order by requested_at

ory · Jun 3, 2022 · 85962db · 85962db
1 parent 53a40ce
commit 85962db
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/persistence/sql/persister_consent.go b/persistence/sql/persister_consent.go
@@ -455,6 +455,7 @@ func (p *Persister) FlushInactiveLoginConsentRequests(ctx context.Context, notAf
 	}
 
 	consent_challenges := []string{}
+	// Order by requested_at field to avoid full scan and use requested_at index
 	queryFormat := `
 	SELECT %[1]s.challenge
 	FROM %[1]s

diff --git a/persistence/sql/persister_oauth2.go b/persistence/sql/persister_oauth2.go
@@ -377,6 +377,7 @@ func (p *Persister) flushInactiveTokens(ctx context.Context, notAfter time.Time,
 	signatures := []string{}
 
 	// Select tokens' signatures with limit
+	// Order by requested_at field to avoid full scan and use requested_at index
 	q := p.Connection(ctx).RawQuery(
 		fmt.Sprintf("SELECT signature FROM %s WHERE requested_at < ? ORDER BY requested_at LIMIT %d",
 			OAuth2RequestSQL{Table: table}.TableName(), limit),