feat: add --skip-logout-consent flag to CLI (#3709)

ory · Jan 31, 2024 · f502d6e · f502d6e
1 parent 4fa2889
commit f502d6e
Show file tree

Hide file tree

Showing 8 changed files with 355 additions and 0 deletions.
diff --git a/cmd/.snapshots/TestCreateClient-case=creates_successfully.json b/cmd/.snapshots/TestCreateClient-case=creates_successfully.json
@@ -16,6 +16,7 @@
   ],
   "scope": "offline_access offline openid",
   "skip_consent": false,
+  "skip_logout_consent": false,
   "subject_type": "public",
   "token_endpoint_auth_method": "client_secret_basic",
   "tos_uri": "",

diff --git a/cmd/.snapshots/TestCreateClient-case=supports_encryption.json b/cmd/.snapshots/TestCreateClient-case=supports_encryption.json
@@ -22,6 +22,7 @@
   ],
   "scope": "offline_access offline openid",
   "skip_consent": false,
+  "skip_logout_consent": false,
   "subject_type": "public",
   "token_endpoint_auth_method": "client_secret_basic",
   "tos_uri": "",

diff --git a/cmd/.snapshots/TestCreateClient-case=supports_setting_flags.json b/cmd/.snapshots/TestCreateClient-case=supports_setting_flags.json
@@ -22,6 +22,7 @@
   ],
   "scope": "offline_access offline openid",
   "skip_consent": false,
+  "skip_logout_consent": false,
   "subject_type": "public",
   "token_endpoint_auth_method": "client_secret_basic",
   "tos_uri": "",

diff --git a/cmd/.snapshots/TestUpdateClient-case=creates_successfully.json b/cmd/.snapshots/TestUpdateClient-case=creates_successfully.json
@@ -16,6 +16,7 @@
   ],
   "scope": "offline_access offline openid",
   "skip_consent": false,
+  "skip_logout_consent": false,
   "subject_type": "public",
   "token_endpoint_auth_method": "client_secret_basic",
   "tos_uri": "",

diff --git a/cmd/.snapshots/TestUpdateClient-case=supports_encryption.json b/cmd/.snapshots/TestUpdateClient-case=supports_encryption.json
@@ -16,6 +16,7 @@
   ],
   "scope": "offline_access offline openid",
   "skip_consent": false,
+  "skip_logout_consent": false,
   "subject_type": "public",
   "token_endpoint_auth_method": "client_secret_basic",
   "tos_uri": "",

diff --git a/cmd/cmd_create_client.go b/cmd/cmd_create_client.go
@@ -39,6 +39,7 @@ const (
 	flagClientScope                             = "scope"
 	flagClientSectorIdentifierURI               = "sector-identifier-uri"
 	flagClientSkipConsent                       = "skip-consent"
+	flagClientLogoutSkipConsent                 = "skip-logout-consent"
 	flagClientSubjectType                       = "subject-type"
 	flagClientTokenEndpointAuthMethod           = "token-endpoint-auth-method"
 	flagClientSecret                            = "secret"

diff --git a/cmd/cmd_helper_client.go b/cmd/cmd_helper_client.go
@@ -41,6 +41,7 @@ func clientFromFlags(cmd *cobra.Command) hydra.OAuth2Client {
 		ResponseTypes:                     flagx.MustGetStringSlice(cmd, flagClientResponseType),
 		Scope:                             pointerx.String(strings.Join(flagx.MustGetStringSlice(cmd, flagClientScope), " ")),
 		SkipConsent:                       pointerx.Bool(flagx.MustGetBool(cmd, flagClientSkipConsent)),
+		SkipLogoutConsent:                 pointerx.Bool(flagx.MustGetBool(cmd, flagClientLogoutSkipConsent)),
 		SectorIdentifierUri:               pointerx.String(flagx.MustGetString(cmd, flagClientSectorIdentifierURI)),
 		SubjectType:                       pointerx.String(flagx.MustGetString(cmd, flagClientSubjectType)),
 		TokenEndpointAuthMethod:           pointerx.String(flagx.MustGetString(cmd, flagClientTokenEndpointAuthMethod)),
@@ -79,6 +80,7 @@ func registerClientFlags(flags *pflag.FlagSet) {
 	flags.String(flagClientName, "", "The client's name.")
 	flags.StringSlice(flagClientPostLogoutCallback, []string{}, "List of allowed URLs to be redirected to after a logout.")
 	flags.Bool(flagClientSkipConsent, false, "Boolean flag specifying whether to skip the consent screen for this client. If omitted, the default value is false.")
+	flags.Bool(flagClientLogoutSkipConsent, false, "Boolean flag specifying whether to skip the logout consent screen for this client. If omitted, the default value is false.")
 
 	// back-channel logout options
 	flags.Bool(flagClientBackChannelLogoutSessionRequired, false, "Boolean flag specifying whether the client requires that a sid (session ID) Claim be included in the Logout Token to identify the client session with the OP when the backchannel-logout-callback is used. If omitted, the default value is false.")

diff --git a/internal/httpclient/go.sum b/internal/httpclient/go.sum