Allow for insecure redirect URI for development

[apognu]

Hi,

This is a feature request.

Currently, even when dangerous-force-http is enabled, there is a hard requirement that all redirect URIs be HTTPS, except for .localhost suffixes (and possibly raw IP adresses). I have to admit this is a pain for development, when using a domain that maps to a private network (Docker, VM, etc.).

The hardcoded .localhost suffix is also problematic, as on some Linux distros (with nss-myhostname), it automatically resolves to 127.0.0.1, bypassing DNS totally (and therefore not hitting my Hydra box), unless the NSS module is totally disabled.

My company also has a policy to use a public TLD for development domains even if the IP is non-routable, and as far as I know, Hydra is not usable like that without a proper DNS certificate.

I totally understand that forcing HTTPS is a feature for production, but I think it would be interesting to either:

• have a flag that marks the instance as non-production (that would remove all HTTPS failsafes);
• or allow for setting which domain are to be whitelisted by the redirect URI failsafe.

Thanks for your input.

[apognu]

I just saw that this is actually handled in fosite, do you want me to open the issue there instead? Any configuration would be done on hydra, but handling would happen in fosite.

[apognu]

And this was apparently discussed already in ory/fosite#273 as wontfix.

Should have searched better beforehand.

[aeneasr]

Flags like --allow-insecure-behaviour are a two-sided sword. On the one side, set ups like yours are much easier to test. On the other, what's used in development often makes it to production. People forget flags like these in Dockerfiles, kubernetes configs, you name it. I was thinking about whitelisting certain domains with a flag but I think it's also a bad idea, because you're apparently mirroring the public TLD but without SSL, so it's incredibly easy to forget that you need to remove this flag later on, and the error won't be caught because it's the same domain.

Is there no other way to work around this for you?

[apognu]

I understand that letting a way to do insecure thing is globally a bad thing, because people tend to choose the easy way over the secure one. If that's your stance, I totally understand it and will not argue this further.

For my particular situation, we do not mirror the public production domain. We have subdomain, unresolvable from the Internet, routable only from private networks and VPNs, that is used for development machines.

.localhost is a bit annoying because it does resolve to the current machine (as I said, through nss-myhostname, enabled on systemd hosts), and does not even allow a Hydra instance in a Docker container.

If the way of not allowing whitelisting domains is kept, I'll continue using a patched fork that adds my internal domain to fosite for my development host, that is not a big deal. :)

[aeneasr]

If that's your stance, I totally understand it and will not argue this further.

Yes, the "mantra" of this ecosystem is to make bad things hard. Another option is of course to add an SSL termination proxy in front of your API gateway or whatever you use, with a certificate that is either issued by an internal-trusted CA or self-issued (and trusted obviously)

[aeneasr]

It makes sense to fix that and lower developer frustration. It makes sense to have --dangerous-force-http to enable http redirect urls as well.

[aeneasr]

We will probably not address this as part of rc.1 but it's on the roadmap for 1.0 stable!

[aeneasr]

Revisiting this, I think it makes sense to have a list of domains whitelisted for development. This would only work when --dangerous-force-http is enabled and probably be a flag like --dangerous-allow-insecure-redirect-urls=http://mydomain.com/callback,http://mydomain2.com/callback. That way we would allow those redirect URLs to be combined with HTTP.

[ghost]

Related issue cropping up when running with dangerous-force-http as an argument passed in using a container context. May not be your issue but I want to link these together for anyone who's digging later: https://github.com/slingshotlabs/reaction-oss-helm-chart/blob/develop/templates/hydra/hydra-deployment.yaml#L38

EDIT

Addressed above with #1354 so great just a config issue for those using dangerous-force-http without dangerous-allow-insecure-redirect-urls when not running using localhost domain.