OAuth2 Token Revoke call results in 404 Not Found

[slax0rr]

I believe I have encountered a bug in the OAuth2Api.RevokeOAuth2Token function in the Go SDK. With both the AdminURL and the PublicURL along with client credentials set in the Configuration, the OAuth2Api struct holds the AdminURL as its Configuration.BasePath value, and a call to the RevokeOAuth2Token then triggers a request to the AdminURL + "/oauth2/token" URL, which results in a 404 Not Found error. I have tried manually overriding the localVarPath in the RevokeOAuth2Token method to use the PublicURL as the BasePath and the request then works normally, and the token is revoked successfully.

Short example:

sdk, _ := hydra.NewSDK(&hydra.Configuration{
    AdminURL: "https://hydra:4445",
    PublicURL: "https://hydra:4444",
    ClientID: "some-client",
    ClientSecret: "some-secret",
}

sdk.RevokeOAuth2Token("some-token value")

Expected behaviour is for the above revoke call to succeed, but the response status code is 404 instead.

Tested in 1.0.0-beta.9

[aeneasr]

Yeah, that's a bug. Feel free to PR!

[aeneasr]

I think the best way to solve is is what @fredbi set on discord: Introduce "admin" and "public" tags to the swagger conf and thus separating the implementations.

[slax0rr]

I do not have enough in-depth knowledge in your SDK yet, but I guess I would simply add the PublicPath to the configuration, with a new NewOAuth2Api method that would accept either a whole Configuration instance or both BasePath and PublicPath, and then let each func decide which path to use for the call.

Edit: if this would be acceptable, I can prepare a PR.