Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent /reject without error data will always return an invalid_request error #1285

Closed
LaylBongers opened this issue Feb 14, 2019 · 1 comment

Comments

@LaylBongers
Copy link

Describe the bug
When rejecting a consent request, but not including "error", "error_description" or "error_hint", the values that aren't given will default to a generic invalid_request error. This is completely inaccurate to what happened and very confusing while developing.

To Reproduce

  1. Go through the OAuth2 authorization code flow until consent
  2. Reject consent, but do not set any value for "error", "error_description" or "error_hint"
  3. Read the resulting error in the callback

Expected behavior
The right behavior should probably be either passing an error that indicates the consent request was rejected, or a generic error. The invalid_request error sends the developer to the wrong place for debugging.

Version:

  • Environment: Docker
  • Version oryd/hydra:v1.0.0-rc.6_oryOS.10
@aeneasr
Copy link
Member

aeneasr commented Feb 14, 2019

Thank you! Feel free to PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants