Fix 1285

[kminehart]

Related issue

#1285

Proposed changes

Summary: Changed the defaults for Name, Description, and Hint from consent/types.go.

Changes:

1. Changed the ToRFCError() function to only provide defaults if all 3 (Name, Description, and Hint) are left blank.
   • I think it's safe to assume that if a developer provides any combination of "Name", "Description", or "Hint", injecting any defaults will cause confusion.
2. Changed the default values of Name, Description, and Hint to be more generic, and clear that they were left blank.
   • Name: "Consent request denied"
   • Description: "The request was denied and no further description was provided"
   • Given no context at the time of generation, no valuable hint could be provided, so it will remain empty.

Checklist

• I have read the contributing guidelines
• I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
  vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
• I signed the Developer's Certificate of Origin
  by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
  amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
  force push.
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation within the code base (if appropriate)
• I have documented my changes in the developer guide (if appropriate)

[aeneasr]

I don't get why crypto is failing all the time. You can fix this with go mod tidy though!

[aeneasr]

Alternatively go get -u golang.org/x/crypto with go modules enabled.

[kminehart]

My bad, go modules are a new thing for me. I ran go mod tidy and committed the go.mod and go.sum files. That should suffice, right?

[aeneasr]

Perfect, last thing would be to add a test so this doesn't break in a future patch by accident :)

[kminehart]

Cool. I wasn't sure what the right place was to put the unit tests for this change, or if they were necessary given the nature of the tests in hydra/consent.

I also am not sure if there needs to be any documentation changes. I couldn't find anything relevant but I could have missed something.

[kminehart]

@aeneasr I think this one is ready.

Pretty basic, if Name is not provided, it'll use the default. Description and Hint no longer have defaults. All of the commits were me just getting used to the way everything is structured. 😅

Looks like there's go mod conflicts so I'll run a rebase again, I guess.

[aeneasr]

Thank you!