Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Add --allowed-cors-origins to client create. #1290

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

jgiles
Copy link
Contributor

@jgiles jgiles commented Feb 27, 2019

This allows the creation of clients permitted to make CORS requests from
specific domains.

Signed-off-by: Josh Giles jgiles@paxos.com

Related issue

This follows up on #957, which added the server feature but not a way to specify the CORS origins in the cli.

Proposed changes

Add a flag for setting the allowed CORS origins.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@aeneasr
Copy link
Member

aeneasr commented Feb 27, 2019

Could you rebase on master? Seems like some issue with go modules.

This allows the creation of clients permitted to make CORS requests from
specific domains.

Signed-off-by: Josh Giles <jgiles@paxos.com>
@jgiles jgiles force-pushed the cmd-allowed-cors-origins branch from bf7699f to 198fb7e Compare February 27, 2019 14:29
@jgiles
Copy link
Contributor Author

jgiles commented Feb 27, 2019

@aeneasr rebased

@aeneasr
Copy link
Member

aeneasr commented Feb 27, 2019

Thank you!

@aeneasr aeneasr merged commit c174f96 into ory:master Feb 28, 2019
@jgiles jgiles deleted the cmd-allowed-cors-origins branch March 2, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants