Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Fix no-open inverted flag check #1306

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

RomanMinkin
Copy link
Contributor

Related issue

Command hydra token user --no-open does not open up the browser since the --no-open flag check is inverted, similar to #1258 and ory/keto#85

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Signed-off-by: Roman Minkin <roman.minkin@keysight.com>
@aeneasr aeneasr merged commit 1aad679 into ory:master Mar 9, 2019
@RomanMinkin RomanMinkin deleted the fix-no-open-flag branch March 11, 2019 16:45
@RomanMinkin
Copy link
Contributor Author

Thank you @aeneasr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants