Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect namespace for PHP SDK #1443

Closed
hoangnd25 opened this issue May 18, 2019 · 4 comments · Fixed by #1468
Closed

Incorrect namespace for PHP SDK #1443

hoangnd25 opened this issue May 18, 2019 · 4 comments · Fixed by #1468

Comments

@hoangnd25
Copy link

hoangnd25 commented May 18, 2019

Describe the bug

Since this commit: b5cb153

PHP SDK is using HydraSDK namespace

However, namespace is set to Hydra\Sdk in composer.json

Reproducing the bug

Steps to reproduce the behavior:

  1. Run composer install
  2. Requires the package

Expected behavior

composer.json should be updated according to the latest sdk

@DASPRiD
Copy link
Contributor

DASPRiD commented May 20, 2019

Interestingly, #1431 changed the composer.json only 10 days ago, when the PHP namespace was apparently Hydra\Sdk, which changed again.

@aeneasr
Copy link
Member

aeneasr commented May 22, 2019

Oh, that's most likely because of swagger-codegen - would you be up for checking what's going on there?

@DASPRiD
Copy link
Contributor

DASPRiD commented May 22, 2019

I'll be out on vacation for the next 7 days, I suppose I could look at it after that when it's not resolved until then. Which namespace is the actual preferred one, Hydra\Sdk oder HydraSDK?

@hoangnd25
Copy link
Author

@aeneasr PHP namespace seems to be HydraSDK now, but the namespace in composer.json file is still Hydra\Sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants