Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: resolve naming inconsistencies #226

Closed
aeneasr opened this issue Aug 22, 2016 · 1 comment
Closed

sdk: resolve naming inconsistencies #226

aeneasr opened this issue Aug 22, 2016 · 1 comment
Assignees
@aeneasr
Labels
breaking change Changes behavior in a breaking manner. feat New feature or request.
Milestone
0.5.0

Comments

@aeneasr
Copy link
Member

aeneasr commented Aug 22, 2016

Right now, key names are JWK, SSO, Client and Policies. We have acronym, acronym, singular, plural. This doesn't make sense. Instead it should be JWKs, SocialLogins, Clients and Policies.
@aeneasr aeneasr added feat New feature or request. breaking change Changes behavior in a breaking manner. labels Aug 22, 2016
@aeneasr aeneasr self-assigned this Aug 22, 2016
@aeneasr aeneasr modified the milestones: 0.5.0, 0.6.0 Sep 7, 2016
@aeneasr aeneasr closed this as completed Sep 7, 2016
aeneasr pushed a commit that referenced this issue Sep 7, 2016
sdk: resolve naming inconsistencies - closes #226
46d31bc
@aeneasr aeneasr mentioned this issue Sep 7, 2016
Merged
@aeneasr
Copy link
Member Author

aeneasr commented Sep 7, 2016

This is now:

    // Clients offers OAuth2 Client management capabilities.
    Clients           *client.HTTPManager

    // SocialConnections offers Social Login management capabilities.
    SocialConnections *connection.HTTPManager

    // JSONWebKeys offers JSON Web Key management capabilities.
    JSONWebKeys       *jwk.HTTPManager

    // Policies offers Access Policy management capabilities.
    Policies          *policy.HTTPManager

    // Warden offers Access Token and Access Request validation strategies (for first-party resource servers).
    Warden            *warden.HTTPWarden

    // Introspection offers Access Token and Access Request introspection strategies (according to RFC 7662).
    Introspection     *hoauth2.HTTPIntrospector

aeneasr pushed a commit that referenced this issue Sep 22, 2016
@arekkas
0.5.0 (#243)
a922002 
* cmd: hydra token user should show id token in browser - closes #224
* cli: hydra clients import doesn't print client's secret - closes #221
* travis: ld flags are wrong - closes #242
* all: resolve naming inconsistencies in jwk set names used in hydra - closes #239
* sdk: resolve naming inconsistencies - closes #226
* docs: resolve gitbook issue with image assets
* jwk: anonymous request can't read public keys - closes #253
* client: add ability to update client - closes #250
* core: document hard-wired JWK sets - closes #247
* docs: fix images in readme - closes #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
breaking change Changes behavior in a breaking manner. feat New feature or request.
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@aeneasr