Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use PublicURL where given #2441

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Conversation

corrideat
Copy link
Contributor

Related issue

#2422

Proposed changes

Use urls.self.public where possible and given, falling back to urls.self.issuer. Well-known URLs are continue to use urls.self.issuer.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

@corrideat corrideat changed the title Fix: Use PublicURL where given fix: Use PublicURL where given Apr 3, 2021
@aeneasr
Copy link
Member

aeneasr commented Apr 4, 2021

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit eefefd5 into ory:master Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants