Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ES256 #2453

Closed
mitar opened this issue Apr 9, 2021 · 7 comments · Fixed by #2828
Closed

Support ES256 #2453

mitar opened this issue Apr 9, 2021 · 7 comments · Fixed by #2828
Labels
good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.

Comments

@mitar
Copy link
Contributor

mitar commented Apr 9, 2021

So fosite has ES256 support, I have seen some past PRs to support ES256 in Hydra (#628, #627), but looking at the code I do not see it really being supported in Hydra.

While RS256 is recommended by the spec, ES256 is close to that with its "Recommended+" recommendation. Supporting ES256 would thus allow one to migrate away from RS256 to ES256.
@aeneasr
Copy link
Member

aeneasr commented Apr 18, 2021

Contribs welcomed!

@aeneasr aeneasr added good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. labels Apr 18, 2021
@dibyajyotibehera
Copy link
Contributor

@aeneasr i can pick this up. However , looks like it was achieved in PR 628 . Wondering how come its missing in master.

@aeneasr
Copy link
Member

aeneasr commented Aug 15, 2021

Yeah also not sure what this is referring to any more. Maybe we can close

@dibyajyotibehera
Copy link
Contributor

actually i don't see the changes merged in PR 628 in master now. Was it intentionally dropped ?

@amaaniqbal
Copy link
Contributor

@aeneasr Should I create a PR with the same changes to the master branch?

@aeneasr
Copy link
Member

aeneasr commented Oct 16, 2021

That PR is from 2017, thats 5 years ago - it probably won’t work ;)

@amaaniqbal
Copy link
Contributor

Oh okay, I missed the date on the PR 😅.

@daniel-shuy daniel-shuy mentioned this issue Oct 30, 2021
Merged
7 tasks
aeneasr pushed a commit that referenced this issue Nov 1, 2021
@daniel-shuy
feat: ES256 for JWK generation (#2828)
5795bc3 
Closes #2453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support ES256 for Create JWT daniel-shuy/hydra
4 participants
@mitar @dibyajyotibehera @aeneasr @amaaniqbal