Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shellcheck to circleci #2832

Closed
5 of 6 tasks
tacurran opened this issue Nov 1, 2021 · 3 comments · Fixed by #2835
Closed
5 of 6 tasks

add shellcheck to circleci #2832

tacurran opened this issue Nov 1, 2021 · 3 comments · Fixed by #2835
Labels
feat New feature or request. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.

Comments

@tacurran
Copy link
Member

tacurran commented Nov 1, 2021

Preflight checklist

Describe your problem

add shellcheck to the ci pipeline for testing and security improvements

Describe your ideal solution

add this orb https://circleci.com/developer/orbs/orb/circleci/shellcheck to the configuration file

Workarounds or alternatives

do nothing (current approach)

Version

v1.10.7

Additional Context

@gr
@tacurran tacurran added the feat New feature or request. label Nov 1, 2021
@aeneasr
Copy link
Member

aeneasr commented Nov 1, 2021

PRs welcomed :)

@aeneasr aeneasr added good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. labels Nov 1, 2021
@hirasawayuki
Copy link
Contributor

@aeneasr Can I take this?

@hirasawayuki hirasawayuki mentioned this issue Nov 3, 2021
Merged
7 tasks
@aeneasr
Copy link
Member

aeneasr commented Nov 3, 2021

yes:)

aeneasr pushed a commit that referenced this issue Nov 9, 2021
@hirasawayuki
feat: add shellcheck to circleci (#2835)
38cbcc0 
Closes #2832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add shellcheck to circleci hirasawayuki/hydra
3 participants
@tacurran @aeneasr @hirasawayuki