Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous call to driver.init() #3093

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

ludydoo
Copy link
Contributor

@ludydoo ludydoo commented Apr 27, 2022

in janitor, driver.Init() is called. Though this is already done in the driver.factory.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@ludydoo ludydoo requested a review from aeneasr as a code owner April 27, 2022 07:43
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #3093 (48dca2f) into master (90523fd) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 48dca2f differs from pull request most recent head 2662053. Consider uploading reports for the commit 2662053 to get more accurate results

@@            Coverage Diff             @@
##           master    #3093      +/-   ##
==========================================
+ Coverage   79.61%   79.64%   +0.03%     
==========================================
  Files         112      112              
  Lines        7958     7955       -3     
==========================================
  Hits         6336     6336              
+ Misses       1219     1217       -2     
+ Partials      403      402       -1     
Impacted Files Coverage Δ
cmd/cli/handler_janitor.go 81.60% <ø> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2bef45...2662053. Read the comment docs.

Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We would still need a connection.Ping() to the database in the driver.init().

@ludydoo
Copy link
Contributor Author

ludydoo commented Apr 27, 2022

@Benehiko yeah that PR is just focused on removing the extraneous driver.Init(). gonna tackle the Ping in another PR

@Benehiko
Copy link
Contributor

Benehiko commented Apr 27, 2022

Thank you! :)
Then I will approve this one once all the tests pass.

@aeneasr aeneasr merged commit 1590542 into ory:master Apr 27, 2022
@vinckr
Copy link
Member

vinckr commented Apr 28, 2022

Hello @ludydoo
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants