-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extraneous call to driver.init() #3093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3093 +/- ##
==========================================
+ Coverage 79.61% 79.64% +0.03%
==========================================
Files 112 112
Lines 7958 7955 -3
==========================================
Hits 6336 6336
+ Misses 1219 1217 -2
+ Partials 403 402 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We would still need a connection.Ping()
to the database in the driver.init()
.
@Benehiko yeah that PR is just focused on removing the extraneous driver.Init(). gonna tackle the Ping in another PR |
Thank you! :) |
Hello @ludydoo |
in
janitor
,driver.Init()
is called. Though this is already done in thedriver.factory
.Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments