Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: limit maximum open connections, document timeout options through DSN #359

Closed
aeneasr opened this issue Jan 12, 2017 · 2 comments
Closed

sql: limit maximum open connections, document timeout options through DSN #359

aeneasr opened this issue Jan 12, 2017 · 2 comments
Labels
feat New feature or request.
Milestone
0.10.0

Comments

@aeneasr
Copy link
Member

aeneasr commented Jan 12, 2017

No description provided.

@aeneasr aeneasr added documentation feat New feature or request. labels Jan 12, 2017
@aeneasr aeneasr added this to the 1.0.0: stable release milestone Jan 12, 2017
@waynerobinson
Copy link

Having a sensible default for MaxIdleConnections is a good idea.

I don't know what the definition of sensible is though, LOL. 10 idle connections?

Being able to override with an environment variable would be even better.

Whilst you're in there with config, being able to set MaxConnections would be good too. Including maybe a maximum sensible default for this too (based on a reasonable expectation about concurrency … like cores * 2 or something).

aeneasr pushed a commit that referenced this issue Jan 13, 2017
sql: limit maximum open connections, document timeout options through…
89d7999 
… DSN - closes #359
aeneasr pushed a commit that referenced this issue Jan 22, 2017
sql: limit maximum open connections, document timeout options through…
01bd815 
… DSN - closes #359
@aeneasr aeneasr closed this as completed Jan 22, 2017
@waynerobinson
Copy link

👌

aeneasr pushed a commit that referenced this issue May 2, 2017
sql: limit maximum open connections, document timeout options through…
6792fde 
… DSN

Closes #359
aeneasr pushed a commit that referenced this issue May 4, 2017
sql: limit maximum open connections, document timeout options through…
bc25c2b 
… DSN

Closes #359
aeneasr pushed a commit that referenced this issue May 7, 2017
@arekkas
sql: limit maximum open connections, document timeout options through…
fa8d15c 
… DSN

Closes #359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request.
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@waynerobinson @aeneasr