Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docker --link should be replaced by networks #555

Closed
drozzy opened this issue Jul 9, 2017 · 1 comment
Closed

docs: docker --link should be replaced by networks #555

drozzy opened this issue Jul 9, 2017 · 1 comment

Comments

@drozzy
Copy link

drozzy commented Jul 9, 2017

Hey guys.
In the tutorial (https://ory.gitbooks.io/hydra/content/install.html) you use the deprecated --link from docker.

I think it should be replaced by the network feature instead: https://docs.docker.com/engine/userguide/networking/#user-defined-networks

This will make tutorial easier to follow for people who don't know about link.

@aeneasr
Copy link
Member

aeneasr commented Jul 9, 2017

Thank you, I took a quick look at networks when writing the guide but it looked like more work to set that up (create network, create container, link container to network, ...). Do you know how to do this? And if yes, would you mind creating a PR?

@aeneasr aeneasr added the docs label Jul 9, 2017
@aeneasr aeneasr changed the title Docker --link should be replaced by networks docs: docker --link should be replaced by networks Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants