Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: Client secret error message should be shown on creation #725

Closed
aeneasr opened this issue Dec 22, 2017 · 0 comments · Fixed by #764
Closed

oauth2: Client secret error message should be shown on creation #725

aeneasr opened this issue Dec 22, 2017 · 0 comments · Fixed by #764
Assignees
Labels
Milestone

Comments

@aeneasr
Copy link
Member

aeneasr commented Dec 22, 2017

Super Trivial issue, I noticed that when trying to create a test client via commandline, I made the client secret only 5 chars. I get the following very weird response in the command window "Could not validate token: invalid character '{' after top-level value" the logs for hydra fortunately had {"code":500,"details":[],"error":"The client secret must be at least 6 characters long","level":"error","msg": so it was easy to track down. I am running v.0.10.0-alpha18, I'm wondering if more recent versions give a better error message for this case

@aeneasr aeneasr added bug Something is not working. package/client package/oauth2 labels Dec 22, 2017
@aeneasr aeneasr added this to the 0.11.0 milestone Dec 22, 2017
@aeneasr aeneasr self-assigned this Dec 22, 2017
@aeneasr aeneasr modified the milestones: 0.12.0, 1.0.0-alpha1 Jan 15, 2018
@zepatrik zepatrik mentioned this issue Feb 6, 2018
aeneasr pushed a commit that referenced this issue Feb 6, 2018
Previously, clients were created despite an error which said that the secret was too short. This patch changes that and improves error output in the CLI as well for this command.

Closes #725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant