Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show client secret when client is public in CLI #737

Closed
aeneasr opened this issue Jan 14, 2018 · 0 comments · Fixed by #765
Closed

Do not show client secret when client is public in CLI #737

aeneasr opened this issue Jan 14, 2018 · 0 comments · Fixed by #765
Assignees
@aeneasr
Labels
bug Something is not working.
Milestone
1.0.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Jan 14, 2018

No description provided.

@aeneasr aeneasr added the bug Something is not working. label Jan 14, 2018
@aeneasr aeneasr added this to the 0.11.0 milestone Jan 14, 2018
@aeneasr aeneasr self-assigned this Jan 14, 2018
@aeneasr aeneasr modified the milestones: 0.12.0, 1.0.0-alpha1 Jan 15, 2018
@zepatrik zepatrik mentioned this issue Feb 6, 2018
Merged
aeneasr pushed a commit that referenced this issue Feb 6, 2018
@zepatrik @arekkas
client: Strips client secret from output when client is public (#765)
439267b 
Previously a newly created public client had a secret send with the initial response and this secret was displayed in the CLI.

Now it is clear that there is no secret needed for public clients. It is not displayed in the CLI anymore.

Closes #737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
bug Something is not working.
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging a pull request may close this issue.

client: do not show/send secret when client is public
1 participant
@aeneasr