Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Build time always return time.Now() #792

Closed
ManassehZhou opened this issue Feb 25, 2018 · 2 comments · Fixed by #799
Closed

docker: Build time always return time.Now() #792

ManassehZhou opened this issue Feb 25, 2018 · 2 comments · Fixed by #799
Labels
bug Something is not working.

Comments

@ManassehZhou
Copy link

it seems in

https://github.com/ory/hydra/blob/master/cmd/root.go#L37:14

it seems this should change into some random string...

screenshot_20180225163452
@aeneasr aeneasr added the bug Something is not working. label Feb 26, 2018
@aeneasr aeneasr changed the title Build time always return time.Now() docker: Build time always return time.Now() Feb 26, 2018
@aeneasr
Copy link
Member

aeneasr commented Feb 26, 2018

I suppose this is docker, right?

@ManassehZhou
Copy link
Author

ManassehZhou commented Feb 26, 2018 •
edited
Loading

Yes, and it can reproduce in the latest release on docker hub and my own build

aeneasr pushed a commit that referenced this issue Mar 3, 2018
cmd: Resolves an issue with broken build time display
77b605d 
Previously, the build time was always the current time. This patch
resolves that issue.

Closes #792
@aeneasr aeneasr mentioned this issue Mar 3, 2018
Merged
aeneasr pushed a commit that referenced this issue Mar 3, 2018
@arekkas
cmd: Resolves an issue with broken build time display (#799)
5c847ea 
Previously, the build time was always the current time. This patch
resolves that issue.

Closes #792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: Resolves an issue with broken build time display ory/hydra
2 participants
@ManassehZhou @aeneasr