Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2: Introspect response is empty when active is false. #964

Closed
aeneasr opened this issue Aug 5, 2018 · 1 comment
Closed

oauth2: Introspect response is empty when active is false. #964

aeneasr opened this issue Aug 5, 2018 · 1 comment
Assignees
@aeneasr
Labels
bug Something is not working. package/cli package/oauth2 package/sdk
Milestone
v1.0.0-beta.8

Comments

@aeneasr
Copy link
Member

aeneasr commented Aug 5, 2018 

docker exec -it hydra_hydra_1 \
>     hydra token introspect \
>     --endpoint http://localhost:4445 \
>     --client-id my-client \
>     --client-secret secret \
>     UDYMha9TwsMBejEvKfnDOXkhgkLsnmUNYVQDklT5bD8.ZNpuNRC85erbIYDjPqhMwTinlvQmNTk_UvttcLQxFJY
{}

should instead return

{ "active": false}
@aeneasr aeneasr added bug Something is not working. package/oauth2 labels Aug 5, 2018
@aeneasr aeneasr added this to the v1.0.0-beta.8 milestone Aug 5, 2018
@aeneasr aeneasr self-assigned this Aug 5, 2018
@aeneasr aeneasr modified the milestones: v1.0.0-beta.8, unplanned Aug 7, 2018
@aeneasr
Copy link
Member Author

aeneasr commented Aug 7, 2018

This is actually caused by the SDK which sets

Active bool `json:"active,omitempty"`

@aeneasr aeneasr modified the milestones: unplanned, v1.0.0-beta.8 Aug 7, 2018
aeneasr pushed a commit that referenced this issue Aug 7, 2018
cli: Print "active:false" when token is inactive
cef6850 
Previously, `omitempty` caused active to be omitted when set to false.

Closes #964

Signed-off-by: arekkas <aeneas@ory.am>
aeneasr pushed a commit that referenced this issue Aug 8, 2018
cli: Print "active:false" when token is inactive
6ac56d1 
Previously, `omitempty` caused active to be omitted when set to false.

Closes #964

Signed-off-by: arekkas <aeneas@ory.am>
@aeneasr aeneasr closed this as completed in 2227691 Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
bug Something is not working. package/cli package/oauth2 package/sdk
Projects
None yet
Milestone
v1.0.0-beta.8
Development

No branches or pull requests
1 participant
@aeneasr