Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: Upgrade to MySQL 1.4 driver #965

Closed
JamesnaW opened this issue Aug 6, 2018 · 5 comments
Closed

vendor: Upgrade to MySQL 1.4 driver #965

JamesnaW opened this issue Aug 6, 2018 · 5 comments
Assignees
@aeneasr
Labels
feat New feature or request. package/cli
Milestone
unplanned

Comments

@JamesnaW
Copy link

JamesnaW commented Aug 6, 2018

Hi all, I have problem with mysql connection. I got connection time out every minute and make hydra crash. I search for this problem and I found this warn from mysql lib https://github.com/go-sql-driver/mysql/wiki/strict-mode. In hydra we use v1.3 right? Can you upgrade to newer version?
@aeneasr aeneasr added the feat New feature or request. label Aug 6, 2018
@aeneasr aeneasr self-assigned this Aug 6, 2018
@aeneasr aeneasr added this to the unplanned milestone Aug 6, 2018
@aeneasr
Copy link
Member

aeneasr commented Aug 6, 2018

Yes, feel free to PR. If you do, please add docs to github.com/ory/docs that explain the new mysql mode.

@aeneasr aeneasr changed the title Mysql connection timeout vendor: Upgrade to MySQL 1.4 driver Aug 6, 2018
@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2018

https://github.com/ory/sqlcon/releases/tag/v0.0.4

@JamesnaW
Copy link
Author

JamesnaW commented Aug 7, 2018

@arekkas you already PR right?

@aeneasr
Copy link
Member

aeneasr commented Aug 7, 2018

yes

@JamesnaW
Copy link
Author

JamesnaW commented Aug 7, 2018

Ok thanks, I just see the comment.

aeneasr pushed a commit that referenced this issue Aug 7, 2018
vendor: Upgrade to latest sqlcon
d633e10 
Closes #965

Signed-off-by: arekkas <aeneas@ory.am>
aeneasr pushed a commit that referenced this issue Aug 7, 2018
cli: Print "active:false" when token is inactive
b50f456 
Previously, `omitempty` caused active to be omitted when set to false.

Closes #965

Signed-off-by: arekkas <aeneas@ory.am>
@aeneasr aeneasr closed this as completed in 74cf642 Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeneasr aeneasr

Labels
feat New feature or request. package/cli
Projects
None yet
Milestone
unplanned
Development

No branches or pull requests
2 participants
@aeneasr @JamesnaW