Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: add oauthapi functions to golang interface #991

Closed
androbi-com opened this issue Aug 19, 2018 · 1 comment
Closed

sdk: add oauthapi functions to golang interface #991

androbi-com opened this issue Aug 19, 2018 · 1 comment

Comments

@androbi-com
Copy link
Contributor

Do you want to request a feature or report a bug?

Complete SDK for Go

What is the current behavior?

In https://github.com/ory/hydra/blob/master/sdk/go/hydra/sdk_api.go the following functions from https://github.com/ory/hydra/blob/master/sdk/go/hydra/swagger/o_auth2_api.go do not show up:

  • OauthAuth
  • OauthToken
  • RevokeAllUserConsentSessions
  • RevokeAuthenticationSession
  • RevokeUserClientConsentSessions
  • RevokeUserLoginCookie
  • Userinfo
  • WellKnown

In the case of the first two I suppose this is intended. But the rest should probably be included? Also, "WellKnown" and the existing "GetWellKnown" are very similar names.

Which version of the software is affected?
latest

@androbi-com androbi-com changed the title Add oauthapi functions to golang interface sdk: add oauthapi functions to golang interface Aug 19, 2018
@aeneasr
Copy link
Member

aeneasr commented Aug 19, 2018

The /oauth2/auth and /oauth2/token endpoints should not be included. They have difficult parameters to handle which should be implemented via a proper library. The others could/should be added (except RevokeUserLoginCookie).

aeneasr pushed a commit that referenced this issue Aug 21, 2018
Closes #991

Signed-off-by: arekkas <aeneas@ory.am>
aeneasr pushed a commit that referenced this issue Aug 21, 2018
Closes #991

Signed-off-by: arekkas <aeneas@ory.am>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants