Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid if condition about SubjectTypesSupport #992

Closed
vvakame opened this issue Aug 21, 2018 · 1 comment
Closed

invalid if condition about SubjectTypesSupport #992

vvakame opened this issue Aug 21, 2018 · 1 comment
Assignees
Milestone

Comments

@vvakame
Copy link

vvakame commented Aug 21, 2018

if stringslice.Has(c.GetSubjectTypesSupported(), "pairwise") {
sias["public"] = consent.NewSubjectIdentifierAlgorithmPublic()
}

this line should compare "public" to c.GetSubjectTypesSupported(), not "pairwise".

@aeneasr
Copy link
Member

aeneasr commented Aug 21, 2018

Thanks, this is definitely a typo but does not cause any issues because that strategy is actually not used :) Cleaning this up anyways.

@aeneasr aeneasr self-assigned this Aug 21, 2018
@aeneasr aeneasr added this to the v1.0.0-rc.1 milestone Aug 21, 2018
@aeneasr aeneasr closed this as completed Aug 21, 2018
@aeneasr aeneasr reopened this Aug 21, 2018
aeneasr pushed a commit that referenced this issue Aug 21, 2018
Closes #992

Signed-off-by: arekkas <aeneas@ory.am>
aeneasr pushed a commit that referenced this issue Aug 21, 2018
Closes #992

Signed-off-by: arekkas <aeneas@ory.am>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants