propagate context through to the sql store

[aaslamin]

With the introduction of #1019 we will need to start propagating the request context down to sql store(s) so we can instrument our database calls.

Notes:

• Creating the spans will be done in a follow-up PR.
• Same thing will need to be done for the other handlers.

[aaslamin]

Unit tests pass for me locally.

[aeneasr]

Would it make sense to propagate context down to other stores too?

[aaslamin]

Yes, it definitely does. Would you like me to do this in this PR @aeneasr?

Edit: I'll just jump on it!

[aaslamin]

ℹ️ Update:

• Client manager and handler have been updated to pass along context
• All consumers have also been updated accordingly

Remaining handlers (will check these on Monday):

• Consent
• JWK

[aaslamin]

@aeneasr at this point I am a bit concerned that the PR is getting too large 😬. Could you review this as is and let me know if you want me to proceed with the Consent and JWK handlers in here or as a separate PR.

They can be 🚀'ed independently.

[aeneasr]

It's definitely a bit larger, but that's fine as there's no functional change so it's very easy to review. So far this looks good to me!

[aeneasr]

Do you want to address the rest of the managers in this PR as well? You can also create another one - it doesn't really matter to me :) Maybe it's best to have the context in one commit (the one I'll squash when merging this)

[aaslamin]

@aeneasr it's all good, i'll do it all in this PR.

Tackling through this now - I shall keep posting updates here as I make progress or find out new things that need doing.

[aaslamin]

Update:

• JWK manager and all of it's clients have been updated ✅

Coming up:

• Updating the JWTStrategy to pass along context where appropriate - (See comment below)
• Updating Consent Manager (this is a biggie 😨) ✅

[aaslamin]

@aeneasr I believe the JWTStrategy interface in fosite needs to be updated to take in a context.

Why?

The implementation of this interface in Hydra makes calls to the db to fetch the latest keys:

• https://github.com/ory/hydra/blob/master/jwk/jwt_strategy.go#L75
• https://github.com/ory/hydra/blob/master/jwk/jwt_strategy.go#L83
• https://github.com/ory/hydra/blob/master/jwk/jwt_strategy.go#L91

The oauth handler consumes the Generate method.

Could you please confirm if this makes sense before I proceed with the plumbing? If so I believe this would require:

• a PR in fosite to update the interface and any tests that break as a result
• a PR in Hydra to pull in the new version of fosite and update the JWTStrategy interface as necessary

[aaslamin]

Update:

Consent Manager and all of its clients have been updated to pass along context. All that is left is the JWT Strategy which I have outlined a plan for above. If that makes sense, I can jump on it.

@aeneasr ready for another review 🙏

[aeneasr]

Ah yeah, that makes sense regarding JWT Strategy. It will also improve the API contract in fosite, which is using context almost everywhere anyways (well, except there and in bcrypt).

[aeneasr]

Wow this is massive! But looks good to me so far!

[aeneasr]

Thank you for your contribution!