Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change go-resty import path for gopkg.in/resty.v1 #1064

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

pierredavidbelanger
Copy link
Contributor

Signed-off-by: Pierre-David Bélanger pierredavidbelanger@gmail.com

This is what we talked about in #1063

go test ./... is all ok

… in its go.mod

Signed-off-by: Pierre-David Bélanger <pierredavidbelanger@gmail.com>
@aeneasr
Copy link
Member

aeneasr commented Oct 1, 2018

All tests are failing, please format and run dep ensure

@pierredavidbelanger
Copy link
Contributor Author

indeed, i am sorry, hahaha, since i am using go mod, I forgot about dep,

Signed-off-by: Pierre-David Bélanger <pierredavidbelanger@gmail.com>
@pierredavidbelanger
Copy link
Contributor Author

I do not know why I had to manually edit Gopkg.toml, but it should work now.

I really am a newbe with Go dep

@aeneasr
Copy link
Member

aeneasr commented Oct 5, 2018

I do not know why I had to manually edit Gopkg.toml, but it should work now.

That's fine :)

@aeneasr aeneasr merged commit 9ec5fbc into ory:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants