Add error response if consent or login challenge is expired #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2018 12:30
Signed-off-by: Kostya Lepa <const.lepa@gmail.com>
Signed-off-by: Kostya Lepa <const.lepa@gmail.com>
aeneasr
reviewed
Oct 16, 2018
There was a problem hiding this comment.
This looks pretty good, thank you! Two things:
- Please add tests:
manager_test.gowould be a good place to check ifWasUsedis set properly- I know that the handler does not have any tests (other than log out right now) but it would be good to see if the GetConsentRequest/GetLoginRequest behave correctly when
WasUsedis set. If you feel lost on how to approach it please let me know and I'll help.
- Please add this behavior to the memory manager as well. All you have to do for that is to iterate over the handled requests like here in the GetLogin/ConsentRequest methods and populate the field accordingly. Alternatively, you could set
WasUsedinHandleConsent/LoginRequestfor theLoginRequest/ConsentRequeststruct.
consent/handler.go
Outdated
| // 500: genericError | ||
| func (h *Handler) GetLoginRequest(w http.ResponseWriter, r *http.Request, ps httprouter.Params) { | ||
| request, err := h.M.GetAuthenticationRequest(r.Context(), ps.ByName("challenge")) | ||
| if err != nil { | ||
| h.H.WriteError(w, r, err) | ||
| return | ||
| } | ||
| if request.WasHandled { | ||
| h.H.WriteError(w, r, pkg.ErrConflict) |
There was a problem hiding this comment.
I think it would be better to have a descriptive error here like the one from the manager: fosite.ErrInvalidRequest.WithDebug("Authentication verifier has been used already").
consent/handler.go
Outdated
| // 500: genericError | ||
| func (h *Handler) GetConsentRequest(w http.ResponseWriter, r *http.Request, ps httprouter.Params) { | ||
| request, err := h.M.GetConsentRequest(r.Context(), ps.ByName("challenge")) | ||
| if err != nil { | ||
| h.H.WriteError(w, r, err) | ||
| return | ||
| } | ||
| if request.WasHandled { | ||
| h.H.WriteError(w, r, pkg.ErrConflict) |
There was a problem hiding this comment.
I think it would be better to have a descriptive error here like the one from the manager: fosite.ErrInvalidRequest.WithDebug("Consent verifier has been used already").
…Request/GetConsentRequest Signed-off-by: Kostya Lepa <const.lepa@gmail.com>
konstlepa
changed the title
|
Done |
|
Thank you, sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The PR fixes #1056.
Thanks