oauth2: wellknown should use corsMiddleware #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
@aeneasr, as discussed in chat. The issue is,
Situation: I have set the CORS_ENABLED=true, but still get No 'Access-Control-Allow-Origin' header is present error when access .well-known/openid-configuration,I checked the logs, there is hydra_1 | time="2018-10-23T11:30:20Z" level=info msg="Enabled CORS" in the log, I also tried set CORS_ALLOWED_ORIGINS=*, but still not work, but it will work in v0.11.12.
Reason: https://github.com/ory/hydra/blob/master/cmd/server/handler.go#L99,
Public server
doesn't use theCORS_ENABLED
flag.Proposed changes
Use
CORS_ENABLED
flag also forpublic server
.Checklist
vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
by signing my commit(s). You can amend your signature to the most recent commit by using
git commit --amend -s
. If youamend the commit, you might need to force push using
git push --force HEAD:<branch>
. Please be very careful when usingforce push.
Further comments