Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binding frontend/backend to unix sockets #1230

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

jayme-github
Copy link
Contributor

This allows the use of strings like "unix:/path/to/socket" as PUBLIC_HOST and/or PRIVATE_HOST.

Signed-off-by: Janis Meybohm meybohm@traum-ferienwohnungen.de

Proposed changes

In some environments (kubernetes for example) securing TCP ports is a little tricky. Supporting unix sockets makes it easy to "hide" the administrative API.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

I'm happy to add docs and tests (if applicable) if you're okay with this addition/change. Please let me know.

@aeneasr
Copy link
Member

aeneasr commented Dec 12, 2018

That's a nice addition! Please add some docs so people are able to find out about this. Good places for that would be:

This allows the use of strings like "unix:/path/to/socket" as
PUBLIC_HOST and/or PRIVATE_HOST.

Signed-off-by: Janis Meybohm <meybohm@traum-ferienwohnungen.de>
Signed-off-by: Janis Meybohm <meybohm@traum-ferienwohnungen.de>
@aeneasr
Copy link
Member

aeneasr commented Dec 13, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants