Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message of too short NEW_SYSTEM_SECRET #1248

Merged
merged 1 commit into from
Dec 27, 2018

Conversation

sawadashota
Copy link
Contributor

Related issue

none

Proposed changes

Show count of NEW_SYSTEM_SECRET length when NEW_SYSTEM_SECRET is too short

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

none

Signed-off-by: Shota SAWADA <xiootas@gmail.com>
@sawadashota sawadashota force-pushed the fix-migrate_secret_error_message branch from a81d79b to 710b0e8 Compare December 27, 2018 08:00
@aeneasr aeneasr merged commit e2d6c44 into ory:master Dec 27, 2018
@aeneasr
Copy link
Member

aeneasr commented Dec 27, 2018

thanks!

@sawadashota sawadashota deleted the fix-migrate_secret_error_message branch December 27, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants