Enable to validate by old system secret #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SECRET` Signed-off-by: Shota SAWADA <xiootas@gmail.com>
sawadashota
force-pushed
the
load_old_system_secret
branch
from
7c2e8d5 to
7ece1fc
Compare
Signed-off-by: Shota SAWADA <xiootas@gmail.com>
sawadashota
force-pushed
the
load_old_system_secret
branch
2 times, most recently
from
471248d to
2165eaa
Compare
Signed-off-by: Shota SAWADA <xiootas@gmail.com>
sawadashota
force-pushed
the
load_old_system_secret
branch
from
2165eaa to
e0dd102
Compare
|
Could you explain in a few sentences what problem this solves? |
|
OK, Set old system secret as environment variable I found 2 causes
Therefore I created this PR! |
|
That makes sense! It was intentional at first to not allow that but it makes sense. Thank you :) |
|
Sorry for my poor description... |
|
Don't worry about it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
none
Proposed changes
Enable to validate by old system secret when setting
ROTATED_SYSTEM_SECRET.Checklist
vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
by signing my commit(s). You can amend your signature to the most recent commit by using
git commit --amend -s. If youamend the commit, you might need to force push using
git push --force HEAD:<branch>. Please be very careful when usingforce push.
Further comments
none