Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Remember to false in payloads with skip #1325

Merged
merged 6 commits into from
Mar 27, 2019
Merged

Default Remember to false in payloads with skip #1325

merged 6 commits into from
Mar 27, 2019

Conversation

kminehart
Copy link
Contributor

@kminehart kminehart commented Mar 26, 2019

Signed-off-by: Kevin Minehart kmineh0151@gmail.com

Related issue

#1165

Proposed changes

Basically, toHandledConsentRequest and toHandledAuthenticationRequest, being only used in a 2 places (and ultimately as a response), now return False for Remember

In the handlers, instead of checking for Remember and Skip, and returning an error if both are true, just set Remember to false (as a skipped request can not be remembered) when Skip is true.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • [-] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
consent/sql_helper.go Outdated Show resolved Hide resolved
consent/sql_helper_test.go Outdated Show resolved Hide resolved
Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
@aeneasr aeneasr merged commit 5b8549a into ory:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants