Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: add support for cockroachdb #1326

Closed
wants to merge 1 commit into from
Closed

all: add support for cockroachdb #1326

wants to merge 1 commit into from

Conversation

lopezator
Copy link
Contributor

add cockroachdb support

Related issue

#990

@lopezator lopezator force-pushed the feature/crdb branch 2 times, most recently from 17d9039 to 75874fc Compare March 26, 2019 13:01
@lopezator
Copy link
Contributor Author

lopezator commented Mar 26, 2019 •
edited
Loading

PTAL just to start discussing about this @aeneasr marked as draft, as work more work is needed.

@lopezator lopezator force-pushed the feature/crdb branch 2 times, most recently from 9633843 to b39f675 Compare March 26, 2019 13:15
@aeneasr
Copy link
Member

aeneasr commented Mar 26, 2019

Thank you for this PR! There's currently a major effort going on which will restructure how internals are instantiated: #1314

Basically, there is a central "registry" (sort of like a ServiceLocator) which is responsible for setting up everything properly. This refactoring will also touch cockroachdb and might even make things a bit easier. I don't think there's a ton that needs to change in this PR for that but it would make sense to rebase on #1314 before merging this. Plan is to have the PR done either by today or by tomorrow, it's fairly far in terms of progress.

@lopezator
Copy link
Contributor Author

Thanks @aeneasr! If that is so advanced I think I can put this on hold for a couple of days and rebase from master once merged.

@aeneasr
Copy link
Member

aeneasr commented Mar 27, 2019

I think that would be the best course of action!

@lopezator lopezator force-pushed the feature/crdb branch 18 times, most recently from f86f2c9 to 9f8c1af Compare April 10, 2019 14:31
@lopezator
all: add cockroachdb support
5cfc3a2 
add cockroachdb support

Signed-off-by: David López <not4rent@gmail.com>
@lopezator lopezator closed this Apr 10, 2019
@lopezator lopezator deleted the feature/crdb branch April 10, 2019 14:41
@lopezator lopezator restored the feature/crdb branch April 10, 2019 14:41
@lopezator lopezator reopened this Apr 10, 2019
@lopezator lopezator closed this Apr 10, 2019
@lopezator lopezator mentioned this pull request Apr 10, 2019
Merged
aeneasr pushed a commit that referenced this pull request May 10, 2019
@lopezator @aeneasr
all: add CockroachDB support (#1348)
f8f2363 
Closes #1326 

Signed-off-by: David López <not4rent@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr will be requested when the pull request is marked ready for review aeneasr is a code owner

@hperl hperl Awaiting requested review from hperl hperl will be requested when the pull request is marked ready for review hperl is a code owner

@alnr alnr Awaiting requested review from alnr alnr will be requested when the pull request is marked ready for review alnr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lopezator @aeneasr