oauth2: Resolve memory leak in gorilla/sessions #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1363 Signed-off-by: aeneasr <aeneas@ory.sh>
|
Would be nice if we had nightly (or weekly if it is $$$$$) load tests for common workflows running in CI so we can catch major regressions faster. Not offering any solutions to 🔝yet, just something to think about! |
|
So we do have a benchmark thingy running but it doesn't check for memory leaks and it also didn't run against the OAuth2 Auth endpoint. Maybe we can enhance that script to include that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1363