-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the endpoint to the warden wrapper #138
Conversation
Signed-off-by: Matteo Suppo <matteo.suppo@gmail.com>
@matteosuppo Looks like you beat me to this by a few hours :) I did basically exactly the same thing, except I didn't add |
Yeah that actually doesn't make sense - I overlooked that in review. I think you can remove all paths in the SDK and just do Endpoint: c.clusterURL, |
could you just replace all |
This is an oversight on my part, I saw what @boyvinall mentioned and didn't bother adding the Endpoint. Overlooked this part: AFAIK Everything else requires correct Endpoint be set. |
Ah yes you're right! Thanks for chipping in! |
@@ -111,7 +111,8 @@ func Connect(opts ...option) (*Client, error) { | |||
} | |||
|
|||
c.Warden = &warden.HTTPWarden{ | |||
Client: c.http, | |||
Endpoint: pkg.JoinURL(c.clusterURL, warden.AllowedHandlerPath), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Endpoint: c.clusterURL,
:)
Fix #137
Without the endpoint the warden client panics