tracing: Add support for B3 headers via the JAEGER_PROPAGATION env var #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ptescher
changed the title
aeneasr
reviewed
Jun 7, 2019
tracing/tracer.go
Outdated
| var configs []jeagerConf.Option | ||
|
|
||
| // This works in other jaeger clients, but is not part of jaeger-client-go | ||
| if os.Getenv("JAEGER_PROPAGATION") == "b3" { |
There was a problem hiding this comment.
Please, instead:
- Add
Propagation stringtoJaegerConfig - Use the
Propagationvalue here (t.JaegerConfig) - Set the value here
- Document the new value around here
To stay compatible it probably makes sense to do something like (assumingJAEGER_PROPAGATIONis a de-facto standard):
Propagation: stringsx.Coalesce(
viper.GetString("JAEGER_PROPAGATION")
viperx.GetString(v.l, "tracing.providers.jaeger.propagation", ""),
),
There was a problem hiding this comment.
Pushed some new changes, let me know if that works. I also added TRACING_PROVIDER_JAEGER_PROPAGATION just for consistency.
ptescher
force-pushed
the
feature/b3-headers
branch
from
fc850a3 to
591d653
Compare
ptescher
added a commit
to ptescher/x
that referenced
this pull request
Jun 10, 2019
Needed for ory/hydra#1456
aeneasr
pushed a commit
to ory/x
that referenced
this pull request
Jun 11, 2019
|
Your changes to ory/x are now released as v0.0.61 |
|
ps: If you rebase on master, the module changes should be up to 0.0.61 |
This will provide compatibility with istio.
ptescher
force-pushed
the
feature/b3-headers
branch
from
591d653 to
2d290fc
Compare
|
@aeneasr all done, tests are passing now. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will provide compatibility with istio.
Fixes #1447